Timeline for pset6 mario/more fails one check50 test despite getting correct output

Current License: CC BY-SA 4.0

7 events

when toggle format	what		by	license	comment
Sep 19, 2018 at 18:03	vote	accept	Kewal Shah
Jun 11, 2018 at 4:26	comment	added	Kewal Shah		Yes but my point is the `check50` test should be something like `rejects non-numeric value` like in the next few codes, instead of `rejects a height of 24, and then accepts a height of 2 expected " # #\n## ##\n", not ""`, because my code fulfills the latter condition, and thanks for sharing the link to the internal error handling of `get_int`
Jun 10, 2018 at 18:30	comment	added	Blauelf		If your code passed the last two tests gracefully (without crashing), then the extra line wouldn't matter. If you're wondering why `get_int` isn't affected, it does multi-step error handling internally (see github.com/cs50/python-cs50/blob/develop/src/cs50/… )
Jun 10, 2018 at 16:26	comment	added	Kewal Shah		Yes, it did work, thank you, but my question is why did that solve the problem? I mean logically it should have passed the cs50 test even without it. In your own answer you have mentioned "for people using input" this problem occurs, so I hope this bug gets fixed
Jun 10, 2018 at 15:34	comment	added	Blauelf		I just put my snippet into your code, and `check50` shows all green.
Jun 10, 2018 at 15:23	comment	added	Kewal Shah		Addressing your second point first, yes I know I haven't done exception handling here, but it in no way affects the result of my check50 test, which is my question and only concern here. Anyway thank you for letting me know about the chain comparison operators, I didn't know that. About the first point, if it is true I sincerely hope the cs50 team notices this issue and fixes this, because it is so unfair to get 85% without my fault! [PS: Any upvotes to this question may bring this to their notice :P ]
Jun 10, 2018 at 15:02	history	answered	Blauelf	CC BY-SA 4.0