PSet2 Vigenere Segmentation Fault Error

Question

I've been struggling with PSet2's Vigenere cipher for a few days now, because of one error that I can't seem to fix. Every time I compile this program, the terminal gives me this error: /opt/sandbox50/bin/run.sh: line 31: 11290 Segmentation fault stdbuf --error=0 --output=0 "$@" Also, the cipher seems to be outputting unicode characters instead of actual letters, such as \u0013.

#include <cs50.h>
#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>


int main(int argc, string argv[])
{

string k = argv[1];
int klen = strlen(k);


if (argc != 2)
{
    printf("Please enter one argument!\n");
    return 1;
}

for (int i = 0; i < klen; i++)
{
    if (isalpha(k[i]) == false)
    {
        printf("Please enter a valid string!");
        return 1;
    }
}

string p = GetString();
int plen = strlen(p);


for (int j = 0; j < klen; j++)
{
    k[j] = toupper(k[j]) - 65;

    for (int i = 0; i < plen; i++)
    {       

        if (isalpha(p[i]))
        {            
            p[i] = (p[i] + k[j]) % 26;
            printf("%c\n", p[i]);
        }
    } 
}
}

Answer 1

To clarify: the error /opt/sandbox50/bin/run.sh: line 31: 11290 .... is from check50, not from compile. It happens when check50 tests for "handles lack of argv[1]". That is because you do string k = argv[1]; before you know if there is an argv[1]. Technically, the segfault comes from the call to strlen(k).

The reason you are getting strange output is here: p[i] = (p[i] + k[j]) % 26;. You are using the ascii value of p[i] (97 for a) instead of the "alphabet index" of p[i] (0 for a). The result of your equation when p[i] = 'a' and k[j] = 'a' will be 19. p[i] needs to be in "alphabet index" for this math to work. The result then needs to be transformed to an ascii value for correct output. Don't forget to keep the correct case of p[i] when you make your corrections.