PSET 3; Find, Helpers.c

Question

So this is the begining step ive taken towards completeing the searching algorithm in helpers.c. What I wanted to know is if im heading in the right direction based off my code so far.

    bool search(int value, int values[], int n)

{ // TODO: implement a searching algorithm

for (int i = 0; i < n; i++)

if (values[i] == values)
{
    return true;
}
return false;

}

I know next i need to implement a sorting algorithm of choice, and then to quicken my searching process, go back and redo my searching algorithm to a bubble sort of choice. Either recursive or iterative. Currently my search is suppose to be in a linear format. Am I checking out okay?

Answer 1

For linear search, this looks almost fine. You have to compare values[i] to value, not to values.

I would probably add some curly braces to the loop like

bool search(int value, int values[], int n)
{
    for (int i = 0; i < n; i++)
    {
        if (values[i] == value)
        {
            return true;
        }
    }
    return false;
}

just to make it clear what is in the loop and what not, and have some consistent indentation (I don't know how much of it got messed up posting the code here, but you'd have more indentation for the for loop's or if's body).