Mario program will not proceed past the spaces

Question

I am having trouble getting the pyramid to print anything more than the first row of spaces, and the number of spaces it prints is not correct; for example, for a height of 4, it prints 4 spaces, not 3. It will also not print the hashtags.

Any advice on how to fix these problems would be greatly appreciated. Thank you!

#include <stdio.h>
#include <cs50.h>

int main(void)
{
int h;
int row;
int space;
int hash;

do
{
    printf("Height: ");
    h = get_int();
}
while (h > 23 || h < 0);

for (row = 0; row < h; row++)
{
    for (space = h - 1; space >= 0; space--)
    {
        printf("-");
    }
    for (hash = 2; hash <= (row + 1); hash++)
    {
        printf("#");
    }
    printf("\n");
}
}

Answer 1

For h = 4, the space loop will execute 4 times and the hash loop will execute 0 times when row is 0. Here's why:

space: for (space = h - 1; space >= 0; space--) is the same as for (space = 3; space >= 0; space--). space >=0 is true for space in {3, 2, 1, 0}, a total of 4 iterations. Since h is constant in this loop, it will always print h spaces.

hash: for (hash = 2; hash <= (row + 1); hash++) is the same as for (hash = 2; hash <= (0 + 1); hash++). Since 2 > 1, it will not execute; 0 iterations.

Work the rest of the rows out in your head or on paper, and you will see it matches the results produced. The next step is to figure out the relationship of space and hash to row and h. That will help you determine the proper number of iterations for each loop.