0

The code works but only not passing substring handling. What is the issue exactly? and any clues on solving it? Thanks.

check50 output

:) dictionary.c, dictionary.h, and Makefile exist
:) speller compiles
:) handles most basic words properly
:) handles min length (1-char) words
:) handles max length (45-char) words
:) handles words with apostrophes properly
:) spell-checking is case-insensitive
:( handles substrings properly
    expected "MISSPELLED WOR...", not "MISSPELLED WOR..."
:| program is free of memory errors
    can't check until a frown turns upside down

code:

// Implements a dictionary's functionality

#include <ctype.h>
#include <stdbool.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include<strings.h>
#include "dictionary.h"

// Represents number of buckets in a hash table
#define N 26

// Represents a node in a hash table
typedef struct node
{
    char word[LENGTH + 1];
    struct node *next;
}
node;

// Represents a hash table
node *hashtable[N];

// Hashes word to a number between 0 and 25, inclusive, based on its first letter
unsigned int hash(const char *word)
{
    return tolower(word[0]) - 'a';
}

//INITIALIZE WORD COUNT
int wcount = 0;

// Loads dictionary into memory, returning true if successful else false
bool load(const char *dictionary)
{
    // Initialize hash table
    for (int i = 0; i < N; i++)
    {
        hashtable[i] = NULL;
    }

    // Open dictionary
    FILE *file = fopen(dictionary, "r");
    if (file == NULL)
    {
        unload();
        return false;
    }

    // Buffer for a word
    char word[LENGTH + 1];
    int hash_new;

    // Insert words into hash table
    while (fscanf(file, "%s", word) != EOF)
    {
        // TODO
        //hash the word
        hash_new = hash(word);

        //create node for new word and fill word in
        node *node_new = malloc(sizeof(node));
        if (node_new == NULL)
        {
            unload();
            return false;
        }
        strcpy(node_new->word, word);

        //set new node pointer
        node_new->next = hashtable[hash_new];

        //set the head to node_new
        hashtable[hash_new] = node_new;

        //increase word count by 1
        wcount++;
    }

    // Close dictionary
    fclose(file);

    // Indicate success
    return true;
}

// Returns number of words in dictionary if loaded else 0 if not yet loaded
unsigned int size(void)
{
    // TODO
    if (wcount > 0)
        return wcount;
    else
        return 0;
}

// Returns true if word is in dictionary else false
bool check(const char *word)
{
    // TODO
    //hash the word
    int hash_word = hash(word);

    //define head pointer and cursor pointer
    node *head = hashtable[hash_word];
    node *cursor = head;

    //traversing over linked list
    while (cursor != NULL)
    {
        int comp = strcasecmp(word, cursor->word);
        if (comp == 0)
            cursor = cursor->next;
        else
            return false;
    }
    return true;
}

// Unloads dictionary from memory, returning true if successful else false
bool unload(void)
{
    // TODO
    for (int i = 0; i < N; i++)
    {
        node *cursor = hashtable[i];
        while (cursor != NULL)
        {
            node *tmp = cursor;
            free(tmp);
            cursor = cursor->next;
        }
        hashtable[i] = NULL;
        return true;
    }
    return false;
1

You have a "small" problem in check function, you actually go through the entire hash table without finding any match. What happens if strcasecmp () is zero? Why do you keep moving forward in the hash table? Why do you return a true rogue at the end of the function? Think, if strcasecmp () == 0, we return true, otherwise we continue checking, the code would be something like:

//traversing over linked list
while (cursor != NULL)
{
    int comp = strcasecmp(word, cursor->word);
    if (comp == 0)
        return true;
    else
        cursor = cursor->next;
}
return false;
1
  • Thanks! Got it fixed!
    – AYA
    Nov 24 '19 at 3:40

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .