0

I already test my code with all possible input and it working fine but when I run with check50 cs50/problems/2020/x/plurality, I got a couple of error result

:( print_winner identifies Bob as winner of election

:( print_winner identifies Charlie as winner of election

Here is my code,

#include <cs50.h>
#include <stdio.h>
#include <string.h>

// Max number of candidates
#define MAX 9

// Candidates have name and vote count
typedef struct
{
    string name;
    int votes;
}




candidate;

// Array of candidates
candidate candidates[MAX];

// Number of candidates
int candidate_count;

// Function prototypes
bool vote(string name);
void print_winner(void);

int main(int argc, string argv[])
{
    // Check for invalid usage
    if (argc < 2)
    {
        printf("Usage: plurality [candidate ...]\n");
        return 1;
    }

    // Populate array of candidates
    candidate_count = argc - 1;
    if (candidate_count > MAX)
    {
        printf("Maximum number of candidates is %i\n", MAX);
        return 2;
    }
    for (int i = 0; i < candidate_count; i++)
    {
        candidates[i].name = argv[i + 1];
        candidates[i].votes = 0;
    }

    int voter_count = get_int("Number of voters: ");

    // Loop over all voters
    for (int i = 0; i < voter_count; i++)
    {
        string name = get_string("Vote: ");

        // Check for invalid vote
        if (!vote(name))
        {
            printf("Invalid vote.\n");
        }
    }

    // Display winner of election
    print_winner();
}

// Update vote totals given a new vote
bool vote(string name)
{

    for(int i=0;i<candidate_count;i++)
    {
        if(strcmp(candidates[i].name,name) == 0){
            candidates[i].votes ++;
            return true;
        }
    }

    return false;
}



// Print the winner (or winners) of the election
void print_winner(void)
{
    // TODO

    candidate result[candidate_count];

    candidate defaultcan;
    defaultcan.name="";
    defaultcan.votes=0;


    for(int i=0;i<candidate_count;i++)
    {
        result[i] = defaultcan;

        if(i==0){
            result[0] = candidates[i];
        }

        if(result[0].votes < candidates[i].votes)
        {

            //clear result
            memset(result, 0, sizeof result);
            result[0] = candidates[i];


        }else if(result[0].votes == candidates[i].votes)
        {

            result[i] = candidates[i];

        }
    }

    for(int i=0;i<candidate_count;i++)
    {
     if( strcmp(result[i].name,"")>0){
              printf("%s\n",result[i].name);
   }

    }
    return;
}

I just want to know how to test my code to get this error?

0

Try: 3 candidates a,b,c 4 voters who vote: a,b,b,c

0
0

i got the same problem as you do and i tried the test 3 candidates a,b,c 4 voters who vote: a,b,b,c. The result i got is a c

I don't understand why it is not properly sorted in this case while in many other case my bubble sort is working.

Could you please explain or give a hint ? Many thanks

Here is my code

#include <stdio.h>
#include <string.h>

// Max number of candidates
#define MAX 9

// Candidates have name and vote count
typedef struct
{
    string name;
    int votes;
}
candidate;

// Array of candidates
candidate candidates[MAX];

// Number of candidates
int candidate_count;

// Function prototypes
bool vote(string name);
void print_winner(void);

int main(int argc, string argv[])
{
    // Check for invalid usage
    if (argc < 2)
    {
        printf("Usage: plurality [candidate ...]\n");
        return 1;
    }

    // Populate array of candidates
    candidate_count = argc - 1;
    if (candidate_count > MAX)
    {
        printf("Maximum number of candidates is %i\n", MAX);
        return 2;
    }
    for (int i = 0; i < candidate_count; i++)
    {
        candidates[i].name = argv[i + 1];
        candidates[i].votes = 0;
    }

    int voter_count = get_int("Number of voters: ");

    // Loop over all voters
    for (int i = 0; i < voter_count; i++)
    {
        string name = get_string("Vote: ");

        // Check for invalid vote

        if (!vote(name))
        {
            printf("Invalid vote.\n");
        }
    }

    // Display winner of election
    print_winner();
}

// Update vote totals given a new vote
bool vote(string name)
{
    for (int i = 0 ; i < candidate_count ; i++)

        if (strcmp(name, candidates[i].name) == 0)
        {
            candidates[i].votes++;
            return true;
        }
    return false;

}

// Print the winner (or winners) of the election
void print_winner(void)
{
    for (int i = 0 ; i < candidate_count - 1 ; i++)
    {
        for (int c = 0 ; c < i - candidate_count - 1 ; c++)
        {
            if (candidates[c].votes < candidates[c + 1].votes)
            {
                int swap = candidates[c].votes;
                candidates[c].votes = candidates[c + 1].votes;
                candidates[c + 1].votes = swap;
            }

        }
    }
    printf("%s\n", candidates[0].name);

    for (int i = 0 ; i < candidate_count - 1 ; i++)
    {
        if ((candidates[i + 1].votes) == (candidates[0].votes))
        {
            printf("%s\n", candidates[i + 1].name);
        }
    }
}

1
  • did you ever figure it out? I am having the same problem and used the same idea (bubble sort). although the test above ouput b, the charlie test is failing for me... – aidan ryan Jun 28 '20 at 4:52

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .