# Problem with plurality

when i check50 my code I get this message :

``````:( print_winner identifies Bob as winner of election
print_winner function did not print winner of election
:( print_winner identifies Charlie as winner of election
print_winner function did not print winner of election
``````

i tried the test 3 candidates a,b,c 4 voters who vote: a,b,b,c. The result i got is a c so there is something wrong but I can't see where.

I don't understand why it is not properly sorted in this case while in many other case my bubble sort is working.

Could you please explain or give a hint ? Many thanks

Here is my code

``````#include <stdio.h>
#include <string.h>

// Max number of candidates
#define MAX 9

// Candidates have name and vote count
typedef struct
{
string name;
}
candidate;

// Array of candidates
candidate candidates[MAX];

// Number of candidates
int candidate_count;

// Function prototypes
bool vote(string name);
void print_winner(void);

int main(int argc, string argv[])
{
// Check for invalid usage
if (argc < 2)
{
printf("Usage: plurality [candidate ...]\n");
return 1;
}

// Populate array of candidates
candidate_count = argc - 1;
if (candidate_count > MAX)
{
printf("Maximum number of candidates is %i\n", MAX);
return 2;
}
for (int i = 0; i < candidate_count; i++)
{
candidates[i].name = argv[i + 1];
}

int voter_count = get_int("Number of voters: ");

// Loop over all voters
for (int i = 0; i < voter_count; i++)
{
string name = get_string("Vote: ");

// Check for invalid vote

if (!vote(name))
{
printf("Invalid vote.\n");
}
}

// Display winner of election
print_winner();
}

// Update vote totals given a new vote
bool vote(string name)
{
for (int i = 0 ; i < candidate_count ; i++)

if (strcmp(name, candidates[i].name) == 0)
{
return true;
}
return false;

}

// Print the winner (or winners) of the election
void print_winner(void)
{
for (int i = 0 ; i < candidate_count - 1 ; i++)
{
for (int c = 0 ; c < i - candidate_count - 1 ; c++)
{
{
}

}
}
printf("%s\n", candidates.name);

for (int i = 0 ; i < candidate_count - 1 ; i++)
{
{
printf("%s\n", candidates[i + 1].name);
}
}
}
``````

The problem is in this condition in your second 'for' loop: `for (int c = 0 ; c < i - candidate_count - 1 ; c++)`. Let's see: Before execute the second loop i = 0 and c = 0. To run the code 'c < i - candidate_count -1' has to be true. if i = 0, and you substrate candidate_count and 1, the result is always going to be negative so the code in the second loop will never execute.
• Hi, thanks for your answer. I changed my second loop to : `for (int c = 0 ; c <= candidate_count - i - 1 ; c++)` but it still doesn't work even though the condition is true this time. I still go the same results Apr 20, 2020 at 13:03