0

I am a (very) beginner coder, so pls be gentle!! I have numerous mistakes in my code, but am unsure how to fix them. The code is working for some things, and I have scored 73 % on the problem set, but I would like to improve this and to find out where I'm making mistakes --> defo in the tabulate part, I know that much! Any pointers would be appreciated :)

#include <stdio.h>
#include <string.h>

// Max voters and candidates
#define MAX_VOTERS 100
#define MAX_CANDIDATES 9

// preferences[i][j] is jth preference for voter i
int preferences[MAX_VOTERS][MAX_CANDIDATES];

// Candidates have name, vote count, eliminated status
typedef struct
{
    string name;
    int votes;
    bool eliminated;
}
candidate;

// Array of candidates
candidate candidates[MAX_CANDIDATES];

// Numbers of voters and candidates
int voter_count;
int candidate_count;

// Function prototypes
bool vote(int voter, int rank, string name);
void tabulate(void);
bool print_winner(void);
int find_min(void);
bool is_tie(int min);
void eliminate(int min);

int main(int argc, string argv[])
{
    // Check for invalid usage
    if (argc < 2)
    {
        printf("Usage: runoff [candidate ...]\n");
        return 1;
    }

    // Populate array of candidates
    candidate_count = argc - 1;
    if (candidate_count > MAX_CANDIDATES)
    {
        printf("Maximum number of candidates is %i\n", MAX_CANDIDATES);
        return 2;
    }
    for (int i = 0; i < candidate_count; i++)
    {
        candidates[i].name = argv[i + 1];
        candidates[i].votes = 0;
        candidates[i].eliminated = false;
    }

    voter_count = get_int("Number of voters: ");
    if (voter_count > MAX_VOTERS)
    {
        printf("Maximum number of voters is %i\n", MAX_VOTERS);
        return 3;
    }

    // Keep querying for votes
    for (int i = 0; i < voter_count; i++)
    {

        // Query for each rank
        for (int j = 0; j < candidate_count; j++)
        {
            string name = get_string("Rank %i: ", j + 1);

            // Record vote, unless it's invalid
            if (!vote(i, j, name))
            {
                printf("Invalid vote.\n");
                return 4;
            }
        }

        printf("\n");
    }

    // Keep holding runoffs until winner exists
    while (true)
    {
        // Calculate votes given remaining candidates
        tabulate();

        // Check if election has been won
        bool won = print_winner();
        if (won)
        {
            break;
        }

        // Eliminate last-place candidates
        int min = find_min();
        bool tie = is_tie(min);

        // If tie, everyone wins
        if (tie)
        {
            for (int i = 0; i < candidate_count; i++)
            {
                if (!candidates[i].eliminated)
                {
                    printf("%s\n", candidates[i].name);
                }
            }
            break;
        }

        // Eliminate anyone with minimum number of votes
        eliminate(min);

        // Reset vote counts back to zero
        for (int i = 0; i < candidate_count; i++)
        {
            candidates[i].votes = 0;
        }
    }
    return 0;
}

// Record preference if vote is valid
bool vote(int voter, int rank, string name)
{
    // DONE!
    //look for candidate called name.
    //if found, update preferences, so that they are the voter's rank preference and return tru
    //if no candidate found, don't update any preferences and return false.
    for (int i = 0; i < candidate_count; i++)
        if (strcmp(name, candidates[i].name) == 0)
        {
            preferences[voter][rank] = i;
            return true;
        }
    return false;

}

// Tabulate votes for non-eliminated candidates
void tabulate(void)
{
    // voter_count stores the number of votes
    //for for a voter i, their top choice -> preferences[i][0], their second choice candidate by preferences[i][1], etc.
    // candidate struct has a field called eliminated
    //candidate struct has a field called votes, which you’ll likely want to update for each voter’s preferred candidate.
    for (int i = 0; i < voter_count; i++)
    {
        for (int x = 0; x < candidate_count; x++)
        {
            if (candidates[preferences[i][x]].eliminated == false)
            {
                candidates[preferences[i][x]].votes ++;
                return;
            }
        }
    }
    return;
    //so, we have added a vote to each candidate that hasn't been eliminated.
    //we need to remember to write code to eliminate candidates!
    
}

// Print the winner of the election, if there is one
bool print_winner(void)
{
    for (int x = 0; x < candidate_count; x++)
    {
        if (candidates[x].votes >= (voter_count / 2))
        {
            printf("%s\n", candidates[x].name);
            return true;
        }
    }
    return false;
}

// Return the minimum number of votes any remaining candidate has
int find_min(void)
{
    // TODO
    for (int x = 0; x < candidate_count; x++)
    {
        int min_votes = (voter_count / 2); //anything with a lower count than the vote count/2
        if (candidates[x].eliminated == false)
        {
            if (candidates[x].votes < min_votes)
            {
                min_votes = candidates[x].votes;
                return 1;
            }
        }
    }
    return 0;
}

// Return true if the election is tied between all candidates, false otherwise
bool is_tie(int min_votes)
{
    // TODO
    
    for (int x = 0; x < candidate_count; x++)
    {
        
        if (candidates[x].eliminated == false)
        {
            if (candidates[x].votes == candidates[x + 1].votes)
            {
                return true;
                //or could try opposite of this; if the candidate isn't eliminated but also doesnt have the least votes
            }
        }
    } 
    return false;
}

// Eliminate the candidate (or candidates) in last place
void eliminate(int min)
{
    // TODO
    for (int x = 0; x < candidate_count; x++)
    {
        if (candidates[x].eliminated == false)
        {
            if (candidates[x].votes == min)
            {
                candidates[x].eliminated = true;
            }
        }
    }
    return;
}

You must log in to answer this question.

Browse other questions tagged .