CS50 Pset3 Plurality

Question

I have issues compiling my program since the last two checks for checkcs50 wont work. It says:problem withprint_winner function did not print both winners of election :( print_winner prints all names when all candidates are tied print_winner function did not print all three winners of election.

What is the problem with my code? Thanks

#include <cs50.h>

#include <stdio.h> #include <string.h>

// Max number of candidates #define MAX 9

// Candidates have name and vote count typedef struct { string name; int votes; } candidate;

// Array of candidates candidate candidates[MAX];

// Number of candidates int candidate_count;

// Function prototypes bool vote(string name); void print_winner(void);

int main(int argc, string argv[]) { // Check for invalid usage if (argc < 2) { printf("Usage: plurality [candidate ...]\n"); return 1; }

// Populate array of candidates
candidate_count = argc - 1;
if (candidate_count > MAX)
{
    printf("Maximum number of candidates is %i\n", MAX);
    return 2;
}
for (int i = 0; i < candidate_count; i++)
{
    candidates[i].name = argv[i + 1];
    candidates[i].votes = 0;
}

int voter_count = get_int("Number of voters: ");

// Loop over all voters
for (int i = 0; i < voter_count; i++)
{
    string name = get_string("Vote: ");

    // Check for invalid vote
    if (!vote(name))
    {
        printf("Invalid vote.\n");
    }
}

// Display winner of election
print_winner();

}

// Update vote totals given a new vote bool vote(string name) { for(int i = 0; i < candidate_count; i++) { if(strcmp(candidates[i].name, name) == 0) { candidates[i].votes++; return true; } } return false; }

// Print the winner (or winners) of the election void print_winner(void) { int votemaximal = 0; for(int i=0; i < candidate_count; i++) { if(candidates[i].votes > votemaximal) {

        votemaximal = candidates[i].votes;
    }
}
for(int i=0; i< candidate_count; i++)
{
    if (candidates[i].votes == votemaximal)
    {
        printf("%s\n, winner", candidates[i].name);
    }
}
return;

}

Answer 1

From the spec

The function should print out the name of the candidate who received the most votes in the election, and then print a newline.

The program must produce the requested output; nothing more, nothing less.

The extra characters after the new line should be removed from this print statement:

printf("%s\n, winner", candidates[i].name);