CS50: pset1 : mario - Errors (Need Help :) )

Question

The following is my work for mario in pset1 and I do not understand the errors' meaning indicated in point 2.

#include <cs50.h>
#include <stdio.h>

int main (void)

{
//Getting user's input for height

int height;

    do
    {
        printf ("Please enter the height within 1 to 23: ");
        height = GetInt();
    }
    while ( height < 1 || height > 23 );

    //a line consist of space and hash
    for (int line = 0; line < height; line++)
    {
          // print spaces
          for ( int space = height - line; space <= line; space--)
          {
             printf ( " " );
          }

          // print hashes
          for ( int hash = 2; hash <= line + 2; hash++ )
          {
             printf ("#");
          }

          // print new line
              printf ("\n");                               
     }    

}  

The following are the errors feedback from CS50 in which I dont understand. i.e. killed by server? exit code? output? Need your help.....

Answer 1

There is a flaw in your While condition of your Do-While loop which would address the first error. When check50 says it expects an exit code of 0, that just means it expects the program to successfully terminate. Based on your error code that isn't happening for an input of 0.

Also, your output for height = 1 is incorrect. It's not the "\n", because you need that new line printed to continue building the pyramid line after line.

Remember that the first line is always a special case with regards to the hashes that need to be printed.

Sorry I can't help more, and am being intentionally vague. But you'll appreciate it so much more when you finally find that bug in your code :)

Answer 2

Get rid of your first printf line. Check50 doesn't like that. I know it seems strange to not have a nice message asking for input, but that's what it wants.

It also doesn't like your new line "\n" operator at the end.