pset3 helpers.c not working

Question

this is my code for the top part

{
    for (int i = 0; i < n; i++)
        {

        if (values[i] == value)
            {
            return true;
            }
        else
            {
            return false;
            }
        }
        return 0;
}

It compiled when I typed make all. However, when I try testing the code with the CS50 example which was supposed to work every time, it returned false.

Answer 1

Hard to see what exactly is going on without getting a look at your wider code but the logic in this loop can't be right.

Your "for" loop will only ever run once because it will return either true or false on its first run. I would suggest that you remove the "else{return false;}" and change "return 0;" to "return false;" at the end - that way false will only be returned if the "for" loop has iterated all comparisons from values[0] to values[n-1].