Compiler Errors in greedy.c

Question

I see the following three Clang compiler errors when I run greedy.c:

jharvard@appliance (~/Dropbox/pset1): make greedy
clang -ggdb3 -O0 -std=c99 -Wall -Werror    greedy.c  -lcs50 -lm -o greedy
greedy.c:7:4: error: expected identifier or '('
   { 
   ^
greedy.c:26:13: error: initializer element is not a compile-time constant
    int i = round (change*100) ;
            ^~~~~~~~~~~~~~~~~~
greedy.c:31:4: error: expected identifier or '('
   {    
   ^
3 errors generated.
jharvard@appliance (~/Dropbox/pset1): 

I ran check50 test of the program.

There is a :! in front of all the items for testing in the problem specification. As far as I can tell this program appears to pass check50 test in spite of the remaining compiler errors.

Can somebody tell me what these compiler errors are and how to eliminate them?

Ramaswami Sastry Vedam

E mail address: [email protected]

Answer 1

 reedy.c:7:4: error: expected identifier or '('
   { 
   ^

This first error is telling you that it doesn't know why you are opening a curly brace there. Without the code, what's goin on?

greedy.c:26:13: error: initializer element is not a compile-time constant
    int i = round (change*100) ;
            ^~~~~~~~~~~~~~~~~~

This looks like it is probably getting confused with the round function. Since you are already multiplying change by 100 and setting that to an int, do you need to round, or will you get the proper value without it?

greedy.c:31:4: error: expected identifier or '('
   {    

Same as the first error. At this point, curly braces are mainly used for opening a loop.

Answer 2

Without seeing your code, here are some guesses: Errors on lines 7 and 31 likely from missing {, (, or preceding line lacks ;. Error on line 26 could be due to declaring i as a global variable, if that's what you're doing declare it in the body.