Pset4 - Recover - Baby Step - trying to create and write 1st Jpg

Question

I am trying to ease into this pset and am having difficulty starting with the first step - locate 1st jpg, create and write. I think that once I have that figured out, I'll have an easier time building out the rest.

1) My code compiles, but produces nothing. 2) I think (I think) that I figured out the difference between sprint (create jpg) and fwrite (write jpg to file). 3) I think that I correctly open and close the card.raw and the new jpg 4) Based on Zamyla's directive, I think I have the order of operation in the loop Lots of thinking, but no certainties:) If anyone can advise on whether or not I'm on the right track, it'd be great. Thanks!

#include <stdio.h>
#include <stdlib.h>
#include <stdint.h>

typedef uint8_t  BYTE;
BYTE buffer[512];
int counter= 0;


int main(int argc, char* argv[])
{    
    FILE* inptr = fopen("card raw", "r");
    if (inptr == NULL)
    {
      printf("Could not open.\n");
      return 2;
    }

    char write_jpg[4];
    int counter=0;
    FILE* jpg = fopen(write_jpg, "w");

    while(fread(&buffer,512,1,inptr) != 0)
   {
    fread(&buffer,512,1,inptr);

    if(buffer[0] == 0xff && buffer[1] == 0xd8 && buffer[2] == 0xff && (buffer[3] == 0xe0 || buffer[3] == 0xe1))
    {
        sprintf(write_jpg,"%03i.jpg",counter);
        jpg = fopen(write_jpg, "w");
        fwrite(&buffer, 512, 1, jpg);
        fclose(jpg);
        counter++;
    }
}   
fclose(inptr); 
}

Answer 1

There are a number of problems. First, you have a typo in fopen("card raw", "r"); You have a space in the filename where there should be a period.

char write_jpg[4]; should be 8, not 4. It's too short to hold the complete filename, so it seg faults.

char write_jpg[4];
int counter=0;
FILE* jpg = fopen(write_jpg, "w");

These three lines declare jpg and open the first output file, but since write_jpg was not actually initialized, the filename is whatever garbage data the system finds at that address, and ends when the system finds some random data that is equal to the end of string marker of \0. You would have done better to set jpg = NULL here.

Next, you have two fread() commands back to back, so you're going to skip half of the data.

Finally, although not incorrect, you have declared 3 global variables outside of main. This is generally considered a bad practice and should be avoided unless there's a good reason for doing so.

This should get you started.

If this answers your question, please click on the check to accept. Let's keep up on forum housekeeping. ;-)