Please. I need some help. When I use Makefile (make) it wont work

Question

#include <cs50.h>
#include <math.h>
#include "helpers.h"



bool search(int needle, int haystack[], int size)
{
    int min = 0;
    int max = size;    

    while(max >= min)
    {
        int mid = (max+min)/2;

        if(haystack[mid] < needle)
        {
            min = mid + 1;
        }
        else if(haystack[mid] > needle)
        {
            max = mid - 1;
        }
        else
        {
            return true;
        }
    }
    return false;
}

//
// Sorts array of n values.
//

void sort(int values[], int n)
    {
        int i,j,temp;
        for (i = 0; i < n; i++)

            for (j = i + 1; j < n; j++) {
               if (values[i] > values[j]) 
               {
                temp = values[i];
                values[i] = values[j];
                values[j] = temp;
                }
        }
        return;
    }

Answer 1

I am sorry this pset has been such a struggle for you. I think you are really close to the finish line. Take a deep breath and let's go through this step by step. The most important thing is that you do not lose the code you have worked so hard on.

The plan:

1. Backup your work. There is no such thing as too much backup.
2. Restore Makefile, find.c and helpers.h from the distro code
3. make the "find" executable
4. Whistle a happy tune

The execution:

1. In a new terminal window:

   cd  pset3
   cp -r find SAVEfind  
   

   This will create a copy of your find directory in a new directory called SAVEfind.

2. Follow the instructions in the Problem Set 3 document to download the distro code, but DO NOT UNZIP. We are going to restore only the 3 files mentioned above. unzip allows you to select the files you wish to retrieve. From your workspace directory:

   unzip pset3.zip pset3/find/Makefile
   unzip pset3.zip pset3/find/find.c
   unzip pset3.zip pset3/find/helpers.h
   

Now you have fresh copies of those three files.

3. Navigate to pset3/find directory and execute make clean. This will ensure that make starts with a clean slate. Now execute make.

I hope I hear whistling! :)

For the record, here is my thinking from reading through your posts. You originally wrote your routines in helpers.c; you added a "main" loop and variables, so it would be a stand-alone program that you could test. That made it difficult to integrate it back into the find application and it was downhill from there. By now you are very frustrated and it makes it difficult to find your way back to where you were when your routines were working.

There's a great discussion of libraries in Week 1 Shorts.

:wq