readability, cs50 segmentation fault, core dump

Question

Hi, I'm having trouble with this. Is there something wrong with my code line or should i just redo everything?

#include <cs50.h>
#include <stdio.h>
#include <ctype.h>
#include <string.h>
#include <math.h>

int main()
{
        string text = get_string("Text: ");

        int letters = 0;
        int words = 1;
        int sentences = 0;

        for (int i = 0; 1 < strlen(text); i++)
        {
            if (isalpha(text[i]))
            {
                letters++;
            }

            else if (text[i] == ' ')
            {
                words++;
            }
            else if (text[i] == '.' || text[i] == '?' || text[i] == '!')
            {
                sentences++;
            }
        }


    float L =  (float) letters /  (float) words * 100;
    float S =  (float) sentences /  (float) words * 100;
    float calculation = (0.0588 * L- 0.296 * S -15.8);
    int index = round(calculation);
    if (index < 1)
     {
         printf("Before Grade 1\n");
     }
     else if (index > 16)
     {
         printf("Grade 16+\n");
     }
     else
     {
         printf("Grade %.of\n", index);
     }
     return 0;
}

Answer 1

This is why it's important that you cut and paste the code, rather than someone transcribing it from an image. Likely would have missed it otherwise. ;-)

The seg fault occurs on line 17:

    for (int i = 0; 1 < strlen(text); i++)

Look closely at this line. There's a typo. Specifically, the test clause has a "1" (the number one) where it should have an i.

You might want to read this post too.
Do YOU know how to find a seg fault?? Advice to new programmers

If this answers your question, please click on the check mark to accept. Let's keep up on forum maintenance. ;-)