Output on Mario

Question

I am not sure how to get the code working the way I want. I think it should make sense. Should I change my approach on the output section to do...while?

int height, space, hash;    

do
{     
    printf("Let's build! Give me a number between 0 and 23 inclusive.\n");
    height = GetInt();
}   
while (height < 0 || height > 23);         

for (height = 0; height <= 23; height++)
{
    for (space = 0; space == (tower_height - 1); space --) 
    {
        printf(" ");
    }

    for (hash = 2; hash == (tower_height + 1); hash ++)           
    {
        printf("#");
    }

    printf ("\n");
}

Answer 1

I found a small but fatal glitch in your code. Have a look on you first loop in output part

for (tower_height = 0; tower_height <= 23; tower_height ++)

A moment before this line in your code, you promted the user to Input height of tower and stored it in the variable tower_height.

And here in for loop you simply initialized it with, tower_height = 0. Hence you simply lost the data you need to process to display that triangle.

Try to declare another variable which start from 0 until it reaches the tower_height

Ex.

for(int i = 0; i < tower_height; i++)
{
    // Second loop
    // code goes here
}

There may be other issues too in the program, but this one was most important to focus at. May be after resolving this issue you get close to your goal.

Wish you all the best

Answer 2

Assuming tower_height, space and hash are declared before the loos, as far as I remember, the do..while loop is used to get valid input from the user. As per the pset specification page, you should accept heights between 0 and 23 inclusive.

For your approach, I see no obvious reasons for iterating till tower_height (assuming it's the height you get from the user) is 23.

Also, space == (tower_height - 1) will be evaluated to false if tower_height - 1 is not 0 initially! It's correct that relation between the initial number of spaces and the height is as follows

initial spaces = height - 1

but that doesn't mean that we should check if spaces == (tower_height - 1). Probably we should assign this value to spaces initially before the loops and decrement it accordingly as we move to the next row using a loop to print space white spaces.

for (int i = 0 to i < space, increment i)
{
    print a whitespace
}
decrement space

It's also correct that the initial number of hashes is 2 and the maximum number of hashes is tower_height + 1, but this also doesn't mean that we should check whether hash == (tower_height + i). Rather, we should set the initial value of hash to 2 before the loops and increment it accordingly as we move to the next row using a loop to print hash hashes.

for (int i = 0 to i < hash, increment i)
{
    print a hash
}
increment hash

Answer 3

If this helps someone else what I needed to do was (aside from fix up my syntax and logic) was introduce 4th int as row.

for (int row = 0; row < tower_height; row ++)
{
    for (space = 0; space < (tower_height - row - 1); space++) 
    {
        // here i want to print spaces as long as space is one less than the tower_height
        printf (" ");
    }    

    for (hash = 0; hash < (row + 2); hash ++)           
    {
        // here i want to print #'s as long as hash is one more than the height
        printf ("#");
    }  

    printf ("\n");