Pset6 check50 version 2 error

Question

My check50 version 1 gives all :) but version 2 gives this result

:) server.c exists
:) server compiles
:( Requesting cat.jpg returns 200, image/jpeg, and correct image
:) Requesting cat.html returns 200, text/html, and correct file
:) Requesting cat2.HTML returns 200, text/html, and correct file
:) Requesting cat3.HtMl returns 200, text/html, and correct file
:( Requesting cat.gif returns 200, image/gif, and correct file
:) Requesting favicon.ico returns 200, image/x-icon, and correct file
:) Requesting test.css returns 200, text/css, and correct file
:) Requesting test.js returns 200, text/javascript, and correct file
:) Requesting hello.php returns 200, text/html, and correct output
:( Requesting hello.php? returns 200, text/html, and correct output
   \ expected output, not an exit code of 0
:( Requesting hello.php?name=Alice returns 200, text/html, and correct output
   \ expected output, not an exit code of 0
:) Requesting /test redirects to /test/
:( Requesting /test/ outputs /test/index.html
:( Requesting directory containing index.php outputs index.php
   \ expected output, but not "HTTP/1.1 403 Forbidden\r\nContent-Type:..."
:( Requesting two files in a row (cat.html then cat.jpg) succeeds

although when I am running ./server public it is showing error 403 Forbidden everytime. Please help me, I will post the code link if you want. Thanks in advance.

EDIT : code deleted as per the rules

Answer 1

INDEXES

:( Requesting /test/ outputs /test/index.html
:( Requesting> directory containing index.php outputs index.php
\ expected> output, but not "HTTP/1.1 403 Forbidden\r\nContent-Type:..."

(And all your 403 problems)

According to man access:

RETURN VALUE
On success (all requested permissions granted, or mode is F_OK and the file exists), zero is returned. On error (at least one bit in mode asked for a permission that is denied, or mode is F_OK and the file does not exist, or some other error occurred), -1 is returned, and errno is set appropriately.

This test ( Requesting /test/ outputs /test/index.html fails because:

[the first] if(access(temp,F_OK)) returns 0. As a boolean, 0 is false, so program proceeds.

[the second] if(access(temp,F_OK)) returns -1. As a boolean, -1 is true. So temp, which has the value /index.php is returned. There is no /index.php => 403 (from somewhere in main).

You should follow the index.php test and see that you will get the same, wrong, result.

My advice: access() returns an int. Treat it like an int. (You don't have to take my word for it; review all the places access() is used in the distro code).

PARSE

:( Requesting hello.php? returns 200, text/html, and correct output
\ expected output, not an exit code of 0
:( Requesting hello.php?name=Alice returns 200, text/html, and correct output
\ expected output, not an exit code of 0

The exit code of 0 usually indicates a seg fault. You need to use gdb to debug this. Tips here to start it up. After you start gdb in a terminal window with a breakpoint set at parse (it's just sitting there waiting for a request), open another terminal session. Execute a curl request, something like curl -i http://localhost:8080/hello.html?name=x. Now back in the gdb terminal, it will be waiting for you to step through parse. This if(line[i]=='?') might be a good place to set another breakpoint.

With patience and perseverance, gdb will help you get a perfect pset6.