Having problems with plurality for cs50

Question

I am trying to run the program for plurality for cs50, and the program compiles I put my candidates in and number of voters and vote, but instead of printing the winner it gives me a segmentation fault. Could someone please help? A copy of my code is below.

Thank you.

include

include

include

// Max number of candidates

define MAX 9

// Candidates have name and vote count typedef struct { string name; int votes; } candidate;

// Array of candidates candidate candidates[MAX];

// Number of candidates int candidate_count;

// Function prototypes bool vote(string name); void print_winner(void);

int main(int argc, string argv[]) { // Check for invalid usage if (argc < 2) { printf("Usage: plurality [candidate ...]\n"); return 1; }

// Populate array of candidates
candidate_count = argc - 1;
if (candidate_count > MAX)
{
    printf("Maximum number of candidates is %i\n", MAX);
    return 2;
}
for (int i = 0; i < candidate_count; i++)
{
    candidates[i].name = argv[i + 1];
    candidates[i].votes = 0;
}

int voter_count = get_int("Number of voters: ");

// Loop over all voters
for (int i = 0; i < voter_count; i++)
{
    string name = get_string("Vote: ");

    // Check for invalid vote
    if (!vote(name))
    {
        printf("Invalid vote.\n");
    }
}

// Display winner of election
print_winner();

}

// Update vote totals given a new vote bool vote(string name) { bool got = false;

for(int y = 0; y < candidate_count; y++)
{
    if(strcmp(name, candidates[y].name) == 0)
    {
        candidates[y].votes += 1;

        got = true;

        break;
    }
}
return got;

}

// Print the winner (or winners) of the election void print_winner(void) { int most = 0;

string winner;

for(int j = 0; j < candidate_count; j++)
{
    if(candidates[j].votes >= most)
    {
        most = candidates[j].votes;

        for(int x = 0; x < candidate_count; x++)
        {
            if(candidates[j].name >= winner)
            {
                winner = candidates[j].name;
            }
        }
    }
}
printf("Winner is %s with %i votes\n", winner, most);

return;

}

Answer 1

You are comparing the string "winner" with "candidates[j].name" without using string comparison function. This might be throwing a "Segmentation Fault" error. Try to fix the below code using "strcmp()".

if(candidates[j].name >= winner)
    {
        winner = candidates[j].name;
    }