CS50P PSet5 Refueling

Question

:( correct fuel.py passes all test_fuel checks expected exit code 0, not 1

when testing my code, which then prevents the following tests from running

Here is my code for fuel.py:

def main():
    fraction = input("Fraction: ")
    percent = convert(fraction)
    return (gauge(percent))


def convert(fraction):
    while True:
        try:
            numerator = int(fraction.split("/")[0])
            denominator = int(fraction.split("/")[1])
            percent = float(numerator / denominator)
            if percent > 1:
                fraction = input("Fraction:")
                continue
        except (ValueError, ZeroDivisionError):
            raise
        else:
             return percent


def gauge(percent):
    if percent >= 0.99:
        return "F"
    elif percent <= 0.01:
        return "E"
    else:
        return f"{percent *100:.0f}%"


if __name__ == "__main__":
    main()

I know this code is 'good' as it passes the original fuel.py tests

My fuel_test.py file looks like this right now:

import pytest
from fuel import convert, gauge

def test_type():
    assert type(convert("1/2")) is float

def test_values():
    assert gauge(0.01) == "E"
    assert gauge(0.99) == "F"

def test_errors():
    with pytest.raises(ValueError):
        convert('value/error')
    with pytest.raises(ZeroDivisionError):
        convert('1/0')

It passes when I run pytest in terminal, so Im at a loss for what is happening here. Any help would be appreciated. THX.

Answer 1

Don't return the result from gauge in main. Return nothing unless there was an error. Print the return from gauge. Most likely this is your issue. Notice that the instructions do not instruct you to have main return anything specific, this means that you should only be returning a non zero value from main in case of error. Even the notice suggests this:

Take care to return, not print, an int in convert and a str in gauge. Only main should call print.

Your main didn't call print, you just returned what you should have printed.

Also the while loop in your convert function is completely unneeded and accomplishes nothing. Additionally your division looks wrong percent = float(numerator/denominator) is casting the result of a integer division to a float value. But you need floating point division.

percent = float(numerator) / float(denominator)