pset6 mario/more fails one check50 test despite getting correct output

Question

My code passes all tests of check50 running check50 cs50/2018/x/sentimental/mario/more except this one:

rejects a height of 24, and then accepts a height of 2 expected " # #\n## ##\n", not ""

I have checked multiple times myself and each time it rejects 24 and shows the correct output for 2, yet I cannot figure out why check50 cannot detect the correct output!

Here's my code:

while True:
    h = int(input("Height: "))
    if h >= 0 and h < 24:
         break

for i in range(h):

    # printing blank spaces in the same row
    for w in range(h - (i + 1)):
        print(" ", end="")

    # printing blocks in the same row
    for b in range(i + 1):
        print("#", end="")

    print("  ", end="")

    # printing blocks in the same row
    for b in range(i + 1):
        print("#", end="")

    # moving down to the next row
    print()

Here's the check50 log

I cannot figure out what is wrong with my code here or is it a bug in check50?

Answer 1

Combination of two mistakes, one on your end, one on their end.

1. The tester seems pass an empty line between the 24 and 2. I'm not sure how this can happen, and it happens only for people using input or cs50.get_string, not for those using cs50.get_int.

   That way, it indirectly compensates for taking a crash for a rejection in the last two tests (empty string or a word). That's where I consider the real problem with the tester, it isn't strict enough at that end.

2. Your programme crashes whenever the input string does not represent an integer. Try input some random word or empty string.

   There are a few approaches how to fix this. One would be to test the input line for consisting of digits only. The other would be to use a try-except block around, like

   while True:
       try:
           h = int(input("Height: "))
           if h >= 0 and h < 24:
               break
       except ValueError:
           pass     # do nothing, keep the loop going
   

   BTW, Python unlike C allows you to chain comparison operators, like if 0 <= h <= 23: