PSET 7 similarities substrings function seems ok but dont pass test

Question

I make a substrings function, it seems to work for me, but i cant pass check.

:( handles one substring in common Expected 1 matches, not 0

:( handles multiple substrings in common Expected 4 matches, not 0

:( handles substrings when strings are identical Expected 4 matches, not 0

:) handles substring length longer than string length

:( handles duplicate substrings in common Expected 4 matches, not 0

[hide solution code]

for i in sub:
    if i not in substring:
        substring.append(i)
    return substring

Answer 1

Your final return substring is indented inside the for loop, rather than running on its own after the loop.